Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-build sbt-metals for sbt2 #7045

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Cross-build sbt-metals for sbt2 #7045

merged 5 commits into from
Dec 19, 2024

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented Dec 18, 2024

I'm not 100% sure what I'm doing, but let's see...

@tgodzik
Copy link
Contributor

tgodzik commented Dec 18, 2024

Thanks! I added testing to be run for the plugin, though it seems enabling semanticdb is duplicating some options. Should we raise it?

@keynmol
Copy link
Contributor Author

keynmol commented Dec 18, 2024

While this was surprisingly easy, there's a bunch of other plugins (for debug adapter) that need to be cross-published for the injected built to even start up.

@keynmol
Copy link
Contributor Author

keynmol commented Dec 18, 2024

though it seems enabling semanticdb is duplicating some options

I think so, seems like bug

@tgodzik
Copy link
Contributor

tgodzik commented Dec 18, 2024

While this was surprisingly easy, there's a bunch of other plugins (for debug adapter) that need to be cross-published for the injected built to even start up.

Forgot about that, we can stop adding it for sbt 2 for now.

@tgodzik
Copy link
Contributor

tgodzik commented Dec 18, 2024

Raised an issue here sbt/sbt#7956

@tgodzik
Copy link
Contributor

tgodzik commented Dec 18, 2024

Ok, so basic test work, but we will not be able to debug yet. We can merge as is if the tests pass. What do you think @keynmol ?

@keynmol
Copy link
Contributor Author

keynmol commented Dec 18, 2024

Let's definitely merge any support - once merged I'll test some more.
Would be good to say that basic metals functionality works in sbt 2 :)

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and we can fix debugging later on.

@tgodzik tgodzik merged commit 652bbe1 into scalameta:main Dec 19, 2024
22 of 23 checks passed
@tgodzik
Copy link
Contributor

tgodzik commented Dec 19, 2024

Thanks @keynmol for raising this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants