-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-build sbt-metals for sbt2 #7045
Conversation
Thanks! I added testing to be run for the plugin, though it seems enabling semanticdb is duplicating some options. Should we raise it? |
While this was surprisingly easy, there's a bunch of other plugins (for debug adapter) that need to be cross-published for the injected built to even start up. |
I think so, seems like bug |
Forgot about that, we can stop adding it for sbt 2 for now. |
Raised an issue here sbt/sbt#7956 |
Ok, so basic test work, but we will not be able to debug yet. We can merge as is if the tests pass. What do you think @keynmol ? |
Let's definitely merge any support - once merged I'll test some more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this and we can fix debugging later on.
Thanks @keynmol for raising this! |
I'm not 100% sure what I'm doing, but let's see...